Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for Bull 4 #38

Closed
arkhamRejek opened this issue Nov 6, 2019 · 5 comments · Fixed by #49
Closed

support for Bull 4 #38

arkhamRejek opened this issue Nov 6, 2019 · 5 comments · Fixed by #49
Labels
help wanted Extra attention is needed

Comments

@arkhamRejek
Copy link

are you guys planning on supporting BullMQ 4 ?

@vcapretz
Copy link
Contributor

hey @arkhamRejek, thanks for bringing this up!

for sure we can look into supporting BullMQ 4. We would need to come up with the best way to do it, either by just bumping bull-board with a major changing or some other API's, if you have any suggestions please feel free to open a PR 😄

@vcapretz vcapretz added the help wanted Extra attention is needed label Nov 10, 2019
@arkhamRejek
Copy link
Author

i'll take a look at their api later on today, someone mentioned that the api was pretty similar to Version 3 so i'll look at this source and get back to you. Great work btw, very beautiful UI.

@alubbe
Copy link

alubbe commented Dec 3, 2019

We're also wanting to upgrade to bull 4 (see bee-queue/arena#199), so if it's helpful we wanted to share that I reached out to Manuel from taskforce.sh and he told me that

  • it should not be very difficult to add support (for bull 4) since it provides a backwards compatibility class that implement most of the old API
  • no more breaking changes (to bull 4) are planned, only fixes for now

@arkhamRejek
Copy link
Author

@alubbe i played around with it a few just been too busy to sit, i hacked together some stuff but hopefully over the christmas break i'll look and see if i can create a pull if someone doesn't beat me to it. kind of hard to get a good read on it as well since the tests are kind of vague as well

@arkhamRejek
Copy link
Author

also the only exception thus far that i'm getting is at gets stats
which is an easy fix since info seems to have been deprecated.

 queue.client.info()

@vcapretz going to need your help on that
after

    const client = await queue.client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants