Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs on bottom #58

Closed
hanskokx opened this issue Jul 24, 2018 · 5 comments
Closed

Tabs on bottom #58

hanskokx opened this issue Jul 24, 2018 · 5 comments
Labels
enhancement New feature or request Fixed in next release This is already fixed and will be included in the next release

Comments

@hanskokx
Copy link
Contributor

When I put the tabs on the bottom, they only move to the bottom when there's more than one tab. I'd prefer to have them always on the bottom.

@felixse
Copy link
Owner

felixse commented Jul 24, 2018

We don't really have tabs when there is only one tab, just a title and a add button.
I'm thinking about moving the add button to the new 'hamburger menu' and showing the title of the current tab when tabs are on bottom. And then finally add a always show tabs option.
Guess this should make everyone happy.

@felixse felixse added the enhancement New feature or request label Jul 24, 2018
@hanskokx
Copy link
Contributor Author

hanskokx commented Jul 24, 2018 via email

@felixse
Copy link
Owner

felixse commented Jul 25, 2018

Yes, it will totally stay in the tab bar, I just want to remove it when there is only one tab. Right now the title looks a bit cramped between the menu and the add tab button

@hanskokx
Copy link
Contributor Author

hanskokx commented Jul 25, 2018 via email

@felixse
Copy link
Owner

felixse commented Jul 25, 2018

yes, that's also an integral part of the 'make everyone happy' package 😄

@felixse felixse added the Fixed in next release This is already fixed and will be included in the next release label Jul 28, 2018
@felixse felixse closed this as completed Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Fixed in next release This is already fixed and will be included in the next release
Projects
None yet
Development

No branches or pull requests

2 participants