Settings option to dump terminal output into file. #438
Conversation
|
Thanks. I've tried this out and it works quite well. Filtering of non-printable characters works but there's still plenty of "unexpected" content in there because of the way terminal updates are done. I don't know if there's much that can be done about that. Putty's "printable characters" logging does the same. Potential future improvement: keyboard binding to enable disable recording on a per-terminal basis |
maxhora
force-pushed
the
mr/log-ouput-to-file-upstream
branch
from
6506013
to
f032cdf
Compare
maxhora
force-pushed
the
mr/log-ouput-to-file-upstream
branch
from
f032cdf
to
c5f9407
Compare
| public void DisplayTerminalOutput(byte terminalId, byte[] output) | ||
| { | ||
| var appSettings = _settingsService.GetApplicationSettings(); |
There was a problem hiding this comment.
still not happy with this. We should keep this as a field and update it on change (I think the UWP is already informing the SystemTray when ApplicationSettings have changed)
There was a problem hiding this comment.
Unfortunately, there is no special Request class to inform SystemTray about changed settings or can't see any other notification mechanism. Going to add SettingsChangedRequest to be sent from UWP to Tray process.
maxhora
force-pushed
the
mr/log-ouput-to-file-upstream
branch
from
c5f9407
to
49b5d4e
Compare
|
@felixse could you please check the the changes one more time, thanks! |
* Settings option to dump terminal output into file. * Notify tray process on settings change.
Introduces Settings options to
ApplicationData.Current.LocalCacheFolder.Pathwhich usually equals toC:\Users\%USERNAME%\AppData\Local\Packages\53621FSApps.FluentTerminal_87x1pks76srcp\LocalCache)Log files are created per terminal session and named to contain session creation timestamp and profile/executable name, for example,
20190708104435232_Powershell.log.Feature requested by https://github.com/jumptrading/FluentTerminal/issues/75