Fix: Allow for spaces in file path #2
Conversation
If a path to a `.po` file had a space, then the `.../tmp/....mo` would also have a space, but this then couldn't be opened by `msgfmt` as that uses spaces to delimit its arguments.
|
hi @GaryJones thanks for the pull request, can you add a new test with the pull request? |
|
@felixzapata Done :-) |
|
I will take a look as soon as possible. I have problems (related with |
| module.exports = gulpPotomo; |
There was a problem hiding this comment.
can you remove the extra line?
There was a problem hiding this comment.
It's usually good practice to have the extra line at the end of files, so that it doesn't flag up the lack of newline character (shown as the red character above, but also shown as "No newline at end of file".
test/test.js
Outdated
| actual.should.equal(expected); | ||
| done(); | ||
| })); | ||
|
|
There was a problem hiding this comment.
can you remove the blank lines (90 and 91) and keep the space columns like the test number 4
There was a problem hiding this comment.
Yes, I can fix this one up.
|
hi @GaryJones , finally I resolved my problems with |
|
@felixzapata The code in the test file was already fairly inconsistent with regard to indentation and clear line spaces, so I've hopefully tidied up all the whitespace to your preference. |
|
@GaryJones I've released the version 1.0.3 |
|
Thank you :-) |
If a path to a
.pofile had a space, then the.../tmp/....mowould also have a space, but this then couldn't be opened bymsgfmtas that uses spaces to delimit its arguments.Here's what it looks like without the fix:
And with the fix: