Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elixir 1.3 Warnings #40

Closed
benwilson512 opened this issue Jun 22, 2016 · 3 comments
Closed

Elixir 1.3 Warnings #40

benwilson512 opened this issue Jun 22, 2016 · 3 comments

Comments

@benwilson512
Copy link

Hey!

Just upgraded to Elixir 1.3, and there's a fair number of warnings, largely about imperative if cases. Happy to look into doing a PR, just thought I'd note it down here first.

Thanks!

  • Ben
@bryanjos
Copy link
Contributor

Hi! I'm sure there are a bunch. A PR would definitely be appreciated. I've been going through my other projects since 1.3 was released and fixing the warnings in those.

@bryanjos
Copy link
Contributor

Small warning: A lot of the code, especially in wkt, wkb, and utils were written when I was still an Elixir newbie and before Elixir 1.0. It might not be fun to look at 😄 . They are on my eventual list to improve.

@benwilson512
Copy link
Author

No problem, I know I sure have plenty of code like that too :)

On Thursday, June 23, 2016, Bryan Joseph notifications@github.com wrote:

Small warning: A lot of the code, especially in wkt, wkb, and utils were
written when I was still an Elixir newbie and before Elixir 1.0. It might
not be fun to look at 😄 . They are on my eventual list to improve.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#40 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAPICS_wILDn_ZX80afXwTQvnWPX52T5ks5qOpTBgaJpZM4I8UCs
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants