Do not raise on unsuccessful cast #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd love to see the ability to return a Changeset error on an unsuccessful cast! |
s3cur3
reviewed
Apr 29, 2024
s3cur3
approved these changes
Apr 30, 2024
|
Thanks so much, @marmor157! 😄 💜 |
|
Included in the newly published v3.7.0 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when there's invalid value(such as empty string) given to the
Geo.PostGIS.Geometry.caseit raises.It's not a perfect solution if we want to use this function when parsing data that comes from outside of the system, like GraphQL request.
To make it more friendly to use I've made so that on unsuccessful cast returns
:errorinstead of raising.