Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new "Add to project" logic #37

Merged
merged 14 commits into from
Aug 22, 2023
Merged

Implement new "Add to project" logic #37

merged 14 commits into from
Aug 22, 2023

Conversation

nyalldawson
Copy link
Collaborator

Copy link
Contributor

@doorgan doorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some observations on the design, we'll do a design review pass on a release candidate, so we can tackle the feedback then. In the meantime, I'd like to know how much of the feedback is doable, and how much is limited by the UI toolkit(in particular the selection color, I have the gut feeling it's globally configured so I'd like to confirm that so we can factor that into the design adjustments)

I also wanted to note that we still can open the plugin without a project open, so we'll like to fix that here or in a different PR

Otherwise, the behavior is correct and works as expected, so it looks good to merge after conflict resolution 👍

  • The selected color is blue on the plugin, and the + placeholder doesn't have a background color:
    Screenshot 2023-08-21 at 15 36 29
    Design:
    Screenshot 2023-08-21 at 15 38 20

  • The designs have an outline color in the thumbnails that isn't present in the plugin:
    Screenshot 2023-08-21 at 15 39 13

Screenshot 2023-08-21 at 15 38 37

  • The thumbnails have a different aspect ratio, they're 4:3 in the design, but they're larger horizontally in the plugin. Our thumbnail images source isn't 4:3, so the plugin will need to crop or resize the image if possible

  • When you first open the plugin dialog, only the option to create a new map is visible due to the scrolling list being too short. We'll likely want to make it taller so at least 1 or 2 maps are visible without having to manually resize the window. In this case it seems to be caused by the notice on non-compatible layers.
    Screenshot 2023-08-21 at 15 46 37

  • In the dark theme, the UI looks light except for the maps list
    Screenshot 2023-08-21 at 16 27 08

  • The maps list doesn't show the last visited date. We don't provide this on the Felt API so I'll be working on that

@nyalldawson nyalldawson reopened this Aug 22, 2023
@migurski migurski merged commit cf91011 into main Aug 22, 2023
9 of 11 checks passed
@migurski migurski deleted the add_to_project branch August 22, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants