Allow selection of workspaces when uploading maps #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doorgan
reviewed
Nov 21, 2023
There was a problem hiding this comment.
This is looking good!
Some notes:
- Let's remove the default "My Workspace"; we'll want you to only be able to create maps in a workspace
- The bottom links should be in the logo header, but they still show at the bottom of the dialog:
Design:
- Similarly, notice that the current logged in user was also moved in the design
|
Ah, I missed those other dialog changes, sorry! What happens when a user has no workspaces created? |
|
@nyalldawson we'll handle that on our side! |
nyalldawson
force-pushed
the
workspace
branch
from
cea133b
to
bd6529d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.