Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility issues with werkzeug 1.0 #112

Closed
mcjlnrtwcz opened this issue Feb 7, 2020 · 5 comments
Closed

Incompatibility issues with werkzeug 1.0 #112

mcjlnrtwcz opened this issue Feb 7, 2020 · 5 comments

Comments

@mcjlnrtwcz
Copy link

mcjlnrtwcz commented Feb 7, 2020

On February 6th a new version of Werkzeug was released: https://pypi.org/project/Werkzeug/#history
It introduces a breaking API change which results in a crash.

Expected Behavior

Proper version of Werkzeug should be installed.

I think flask-session should use fixed version of flask - I reported the problem here pallets/flask#3490

Actual Behavior

Flask application can't be tested.

/usr/lib/python3.7/unittest/mock.py:1204: in patched
    return func(*args, **keywargs)
doobar/test_utils/fixtures.py:72: in _stubbed_app
    return create_app('test')
doobar/__init__.py:41: in create_app
    Session(app)
venv/lib/python3.7/site-packages/flask_session/__init__.py:54: in __init__
    self.init_app(app)
venv/lib/python3.7/site-packages/flask_session/__init__.py:61: in init_app
    app.session_interface = self._get_interface(app)
venv/lib/python3.7/site-packages/flask_session/__init__.py:93: in _get_interface
    config['SESSION_USE_SIGNER'], config['SESSION_PERMANENT'])
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <flask_session.sessions.FileSystemSessionInterface object at 0x7f38e4d255c0>, cache_dir = '/tmp/doobar-sessions', threshold = 500, mode = 384, key_prefix = 'session:'
use_signer = False, permanent = True

    def __init__(self, cache_dir, threshold, mode, key_prefix,
                 use_signer=False, permanent=True):
>       from werkzeug.contrib.cache import FileSystemCache
E       ModuleNotFoundError: No module named 'werkzeug.contrib'

venv/lib/python3.7/site-packages/flask_session/sessions.py:313: ModuleNotFoundError

Environment

  • Python version: 3.7
  • Flask version: 1.1.1
  • Werkzeug version: 1.0
@SqrtMinusOne
Copy link
Contributor

Added a PR to fix this #114

@jakabk
Copy link

jakabk commented Feb 20, 2020

Please merge the PR and release, plz, plz, plz.

@rayluo
Copy link
Contributor

rayluo commented Mar 28, 2020

FYI: I encounter same problem, and I fixed it in my fork, and you can install it in this way.

@VictorSyntez
Copy link

FYI: I encounter same problem, and I fixed it in my fork, and you can install it in this way.

Thank you!

@fengsp
Copy link
Contributor

fengsp commented May 14, 2020

Fixed since 0.3.2.

@fengsp fengsp closed this as completed May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

6 participants