Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on interaction with contributor #55

Closed
fennifith opened this issue Sep 18, 2018 · 1 comment
Closed

Crash on interaction with contributor #55

fennifith opened this issue Sep 18, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@fennifith
Copy link
Owner

Pretty sure this is just a case of an empty URL string being passed to the UrlClickListener class. Weird stack trace though.

E/AndroidRuntime: FATAL EXCEPTION: main
                  Process: me.jfenn.attriboutersample, PID: 20401
                  android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.intent.action.VIEW dat= (has extras) }
                      at android.app.Instrumentation.checkStartActivityResult(Instrumentation.java:1816)
                      at android.app.Instrumentation.execStartActivity(Instrumentation.java:1525)
                      at android.app.Activity.startActivityForResult(Activity.java:4317)
                      at androidx.fragment.app.FragmentActivity.startActivityForResult(FragmentActivity.java:767)
                      at android.app.Activity.startActivityForResult(Activity.java:4276)
                      at androidx.fragment.app.FragmentActivity.startActivityForResult(FragmentActivity.java:754)
                      at android.app.Activity.startActivity(Activity.java:4600)
                      at androidx.core.content.ContextCompat.startActivity(ContextCompat.java:248)
                      at androidx.browser.customtabs.CustomTabsIntent.launchUrl(CustomTabsIntent.java:263)
                      at me.jfenn.attribouter.utils.UrlClickListener.onClick(UrlClickListener.java:19)
                      at android.view.View.performClick(View.java:5623)
                      at android.view.View$PerformClick.run(View.java:22433)
                      at android.os.Handler.handleCallback(Handler.java:751)
                      at android.os.Handler.dispatchMessage(Handler.java:95)
                      at android.os.Looper.loop(Looper.java:154)
                      at android.app.ActivityThread.main(ActivityThread.java:6316)
                      at java.lang.reflect.Method.invoke(Native Method)
                      at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:872)
                      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:762)
@fennifith fennifith added the bug Something isn't working label Sep 18, 2018
@fennifith
Copy link
Owner Author

I was right. Added an empty check to the LinkWedge that was creating it & told the ContributorWedges to ignore null listeners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant