configure.ac: Use PKG_PROG_PKG_CONFIG macro #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal of this commit is to fix an error encountered when building
2.13 on Chromium OS.
emerge-${board} powertop
<snip>
checking for libnl-3.0 >= 3.0 libnl-genl-3.0 >= 3.0... yes
checking for library containing inet_aton... none required
* pkg-config: ERROR: Do not call unprefixed tools directly.
* pkg-config: ERROR: For board tools, use `tc-export PKG_CONFIG` (or ${CHOST}-pkg-config).
* pkg-config: ERROR: For build-time-only tools, `tc-export BUILD_PKG_CONFIG` (or ${CBUILD}-pkg-config).
* python3 /mnt/data/chromiumos/chromite/bin/cros_sdk --enter --chrome_root=chrome_root
* `-python3 /mnt/data/chromiumos/chromite/bin/cros_sdk --enter --chrome_root=chrome_root
* `-bash
* `-emerge -b /usr/lib/python-exec/python3.6/emerge --root-deps powertop
* `-sandbox /usr/lib/portage/python3.6/ebuild.sh configure
* `-ebuild.sh /usr/lib/portage/python3.6/ebuild.sh configure
* `-ebuild.sh /usr/lib/portage/python3.6/ebuild.sh configure
* `-configure ./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-cros-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --disable-dependency-tracking --disable-silent-rules --docdir=/usr/share/doc/powertop-2.13 --htmldir=/usr/share/doc/powertop-2.13/html --with-sysroot=/build/volteer --libdir=/usr/lib64 --disable-nls
* `-pkg-config /build/volteer/tmp/portage/sys-power/powertop-2.13/temp/build-toolchain-wrappers/pkg-config --exists bash-completion
* `-pstree -a -A -s -l 10567
* ERROR: sys-power/powertop-2.13::portage-stable failed (configure phase):
* Bad pkg-config [--exists bash-completion] invocation
<snip>
The environment variable is populated for board specific tooling.
declare -x PKG_CONFIG="/build/volteer/build/bin/pkg-config"
Signed-off-by: Ed Baker <edward.baker@intel.com>
|
Hey @thac0 are there specific build situations I can check to help? Otherwise I can fire up a few VMs with common Linux distributions and give it a double check. Let me know what helps. |
edwarddavidbaker
added a commit
to edwarddavidbaker/gentoo
that referenced
this pull request
Sep 17, 2020
Originally submitted as pull request at fenrus75/powertop#68. Signed-off-by: Ed Baker <edward.baker@intel.com>
|
This looks good to me, FWIW. I'd like to see this upstream before I apply the patch to Gentoo. |
|
Thanks, @edwarddavidbaker and @mattst88 |
|
Thank you! |
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Sep 24, 2020
Originally submitted as pull request at fenrus75/powertop#68. Signed-off-by: Ed Baker <edward.baker@intel.com> Closes: #17579 Signed-off-by: Matt Turner <mattst88@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this commit is to fix an error encountered when building 2.13 on Chromium OS.
The environment variable is populated for board specific tooling.