senc does not emit any error messages for failure scenarios

[robmorgan]

senc doesn't seem to work for me. If I manually run it:

cd senc
mkdir -p out
cargo run -- -l trace -o ./_ci ./out

I get the following output:

Finished dev [unoptimized + debuginfo] target(s) in 0.15s
     Running `target/debug/senc -l trace -o ./_ci ./out`
TRACE: [84054582-022a-4cc4-94cf-9816ed2435c4] Worker started.
TRACE: [390ef900-c492-4c9e-a3e8-686ed884916a] Worker started.
TRACE: [84054582-022a-4cc4-94cf-9816ed2435c4] Worker disconnected; shutting down.
TRACE: [8ae14d12-70dd-4d13-a5f3-cda53414474f] Worker started.
TRACE: [82b9f2c9-d837-4158-9fc6-8391ac646e97] Worker started.
TRACE: [c099d01a-fcba-4a68-8a43-6915cca3bd30] Worker started.
TRACE: [82b9f2c9-d837-4158-9fc6-8391ac646e97] Worker disconnected; shutting down.
TRACE: [c099d01a-fcba-4a68-8a43-6915cca3bd30] Worker disconnected; shutting down.
TRACE: [df400229-a3b5-4742-8873-18f3cc5f7515] Worker started.
TRACE: [c0c64671-1382-4786-b9c3-961abd856620] Worker started.
TRACE: [90069fad-7ce7-4054-b0c2-3f6173b2ceb9] Worker started.
TRACE: [8ae14d12-70dd-4d13-a5f3-cda53414474f] Worker disconnected; shutting down.
TRACE: [c0c64671-1382-4786-b9c3-961abd856620] Worker disconnected; shutting down.
TRACE: [90069fad-7ce7-4054-b0c2-3f6173b2ceb9] Worker disconnected; shutting down.
TRACE: [390ef900-c492-4c9e-a3e8-686ed884916a] Worker disconnected; shutting down.
TRACE: [df400229-a3b5-4742-8873-18f3cc5f7515] Worker disconnected; shutting down.
TRACE: [df400229-a3b5-4742-8873-18f3cc5f7515] waiting for worker
TRACE: [7f692fa2-6e2c-4bc2-a811-7ab6860e3db0] Worker started.
TRACE: [847ee1a4-7fc9-4d24-b15f-5f740221b1d2] Worker started.
TRACE: [7f692fa2-6e2c-4bc2-a811-7ab6860e3db0] Worker disconnected; shutting down.
TRACE: [847ee1a4-7fc9-4d24-b15f-5f740221b1d2] Worker disconnected; shutting down.
TRACE: [390ef900-c492-4c9e-a3e8-686ed884916a] waiting for worker
TRACE: [8ae14d12-70dd-4d13-a5f3-cda53414474f] waiting for worker
TRACE: [c099d01a-fcba-4a68-8a43-6915cca3bd30] waiting for worker
TRACE: [7f692fa2-6e2c-4bc2-a811-7ab6860e3db0] waiting for worker
TRACE: [c0c64671-1382-4786-b9c3-961abd856620] waiting for worker
TRACE: [90069fad-7ce7-4054-b0c2-3f6173b2ceb9] waiting for worker
TRACE: [847ee1a4-7fc9-4d24-b15f-5f740221b1d2] waiting for worker
TRACE: [84054582-022a-4cc4-94cf-9816ed2435c4] waiting for worker
TRACE: [82b9f2c9-d837-4158-9fc6-8391ac646e97] waiting for worker

The same goes if I build using cargo release or download a pre-compiled binary.

It doesn't seem to actually generate anything in my out dir. I'm using the included _ci example. Could it be search for global node_modules or something?

[yorinasub17]

Hmm I need to investigate this, but off the top of my head, did you run pnpm install in _ci before running senc?

[robmorgan]

Nope no pnpm at all, but I did do another test with yarn and got the same result. I’ll try with pnpm tomorrow. Besides that I can successfully execute and debug the tests I’ve tried. I can see the right objects and data being constructed.

…

On Fri, 5 Apr 2024 at 8:10 pm, Yoriyasu Yano ***@***.***> wrote: Hmm I need to investigate this, but off the top of my head, did you run pnpm install in _ci before running senc? — Reply to this email directly, view it on GitHub <#49 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABLV66ZIQ74F6XB3MF6RXLY32IDFAVCNFSM6AAAAABFYRM4UCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZZGYZTONJYGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[robmorgan]

I've noticed some of the tests are complaining about lodash. I'm not sure if it's related...

running 16 tests
test engine::tests::test_engine_runs_code_with_config_yaml_import ... ok
thread 'test engine::tests::test_engine_runs_code_with_config_json_import ... engine::tests::test_engine_runs_code_with_node_modulesok' panicked at '
error running js: node package lodash-es does not have a package.json file', src/engine.rs:824:14
test engine::tests::test_engine_runs_code_with_builtin_filefunctions ... ok
stack backtrace:
test engine::tests::test_engine_fails_code_with_import_outside_projectroot ... ok
test engine::tests::test_engine_prepends_hcl_prefix_if_set ... ok
test engine::tests::test_engine_prepends_prefix_if_set ... ok
test engine::tests::test_engine_runs_js_with_args ... ok
test engine::tests::test_engine_runs_code_with_out_data_output ... ok
test engine::tests::test_engine_runs_code_with_out_data_list_output ... ok
test engine::tests::test_engine_runs_js ... ok
test engine::tests::test_engine_runs_ts ... ok
test engine::tests::test_engine_checks_schema_pass ... ok
test engine::tests::test_engine_checks_schema_fail ... ok
   0: rust_begin_unwind
             at /rustc/8ede3aae28fe6e4d52b38157d7bfe0d3bceef225/library/std/src/panicking.rs:593:5
   1: core::panicking::panic_fmt
             at /rustc/8ede3aae28fe6e4d52b38157d7bfe0d3bceef225/library/core/src/panicking.rs:67:14
   2: core::result::unwrap_failed
             at /rustc/8ede3aae28fe6e4d52b38157d7bfe0d3bceef225/library/core/src/result.rs:1651:5
   3: core::result::Result<T,E>::expect
             at /rustc/8ede3aae28fe6e4d52b38157d7bfe0d3bceef225/library/core/src/result.rs:1033:23
   4: senc::engine::tests::check_single_json_output_with_args::{{closure}}
             at ./src/engine.rs:822:22
   5: senc::engine::tests::check_single_json_output::{{closure}}
             at ./src/engine.rs:806:81
   6: senc::engine::tests::test_engine_runs_code_with_node_modules::{{closure}}
             at ./src/engine.rs:566:81

// <rest omitted for brevity>

[yorinasub17]

Ah yes you need to run pnpm install in the fixtures directory.

[robmorgan]

yeah the tests all pass once you run pnpm install in the fixtures directory, but I still can't get the _ci sources building:

cd _ci && pnpm install
mkdir -p out
cargo run -- -l trace -o ./_ci ./out

I'll keep investigating.

[robmorgan]

Okay I've figured it out. One was a dumb use of CLI args by me. I was doing:

cargo run -- -l trace -o ./_ci ./out

When I actually needed to do:

cargo run -- ./_ci -o ./out -l trace

Another potential issue is I noticed is files::find_node_modules_dir is resolving my global node_modules dir (Users/robbym/node_modules). It's walking from my GOROOT up to my home folder. I know there's a bit of a trend now days to move away from global node_modules, but I wanted to check that this is the expected behaviour?

[yorinasub17]

Ah yes the behavior of walking up the tree to find node_modules is intended (since otherwise I can't implement hierarchical node_modules support in monorepos), but the lack of error messages is not. I'm going to rename this issue for tracking that part of the problem.