Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow decrypting keys with a passphrase #25

Closed
wants to merge 3 commits into from
Closed

allow decrypting keys with a passphrase #25

wants to merge 3 commits into from

Conversation

Forum1877621
Copy link

No description provided.

@ferama
Copy link
Owner

ferama commented Jan 16, 2023

Thanks for your work, but I'm sorry to say that at current status this pull request is not acceptable.

What needs to be improved

  1. tests doesn't run correctly
  2. ssh client configuration must be in sshc/conf.go and needs to be applicable to config file
  3. cache package you introduced is unwanted / unneeded (there is already the config mechanism)

About the point 2, rospo can use a config file too. Using the config file rospo needs to run without user interaction. The introduction of password encrypted keys, must be supported by config file too.

@Forum1877621
Copy link
Author

I use command line only so I don't want to spend time adding config file support, sorry
idk enough about go to know why the tests are failing in github, they work on my dev machine

@Forum1877621 Forum1877621 closed this by deleting the head repository Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants