Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add goreleaser #6

Closed
wants to merge 1 commit into from
Closed

Add goreleaser #6

wants to merge 1 commit into from

Conversation

yarlson
Copy link

@yarlson yarlson commented Aug 5, 2021

No description provided.

@ferama
Copy link
Owner

ferama commented Aug 5, 2021

Thanks @yarlson :)

Seems a good starting point but the release should be performed automatically from the CI tools (from here https://github.com/ferama/rospo/blob/main/.github/workflows/main.yml)

It could be useful also to merge the docker pipeline with the main pipeline. From what I see goreleaser supports build/push of docker images too (but this one could be the subject for another PR)

Anyway to be merged it should at least:

  1. include test running into the release.sh script and fail if test fails
  2. provide CI integration (adapting .github/workflows/main.yml)
  3. the build process must correctly set the ldflags (look at the build.sh file)

about the point 3, we need to set the github.com/ferama/rospo/cmd.Version value. This is needed to make the flag

$ rospo -v
rospo version 0.6.3

to work correctly.

Thanks

@ferama ferama closed this Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants