Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: import issues template from ferdium-recipes #948

Merged

Conversation

nathanaelhoun
Copy link
Contributor

@nathanaelhoun nathanaelhoun commented Feb 15, 2023

Pre-flight Checklist

Please ensure you've completed all of the following.

Motivation and Context

As discussed in the maintainer team, we are merging the recipes issues tracker into the app issue tracker, to reduce duplicates and simplify management.

This PR contains the updated issues templates, with some tweaks to remove dead links and redondant informations.

The result can be seen (and tested) in this fork: https://github.com/nathanaelhoun/ferdium-app/issues/new/choose

Migration checklist

Release Notes

Merged issues tracker for the main app and recipes to reduce duplicates

@vraravam vraravam force-pushed the include-recipes-issues-into-main-repo branch from 12dff82 to fcd58b0 Compare February 16, 2023 01:16
@vraravam vraravam merged commit b6bfeae into ferdium:develop Feb 16, 2023
@nathanaelhoun
Copy link
Contributor Author

All opened issues of ferdium-recipes has been migrated to ferdium-app successfully!

@mh166
Copy link

mh166 commented Mar 30, 2023

Disable issues in the recipes repo useless because the new issue templates for recipes prevent to create an issue, and so we can keep the history of closed issues.

I'm not so sure about that... 😉

When opening .../ferdium-app/issues/new, it redirects to the template selection page. When opening .../ferdium-recipes/issues/new, it stays on that page and you're free to submit a new issue, despite the template saying otherwise. Have you configured anything differently in ferdium-recipes than in ferdium-app?

@Alphrag
Copy link
Member

Alphrag commented Mar 30, 2023

When opening .../ferdium-app/issues/new, it redirects to the template selection page. When opening .../ferdium-recipes/issues/new, it stays on that page and you're free to submit a new issue, despite the template saying otherwise.

For me using these url both directs to an issue creation without any template. If you however go to [repo]/issues/new/choose then you will see the possible templates appear, and in the ferdium-recipes repository, this will redirect you to the ferdium-app issues. It seems that github works that way, and I can't see a way to remove/redirect the internal url [repo]/issues/new unfortunately. However, we expect people to open issues by going on github and clicking on "New issue" which will trigger the templates.
How did you get to these urls directly? If this is encoded somewhere, please let us know and we will change them for the appropriate placeholders, so that it works as expected 🙂

@mh166
Copy link

mh166 commented May 8, 2023

Sorry for the late reply. Found two ways to get there, one of which you could fix. ;)

The easy one would be an update to ferdium-recipes/docs/integration.md on L9. I thought about just opening a PR, but I wasn't sure if any of the docs would need remodeling anyway, because of the shift in handling stuff. 🤷

The other one, which originally led me astray, comes down to faulty behavior on GitHub's side. I reported it to them already:

  1. Make sure you're not logged in (e.g. use incognito tab)
  2. Open a repo with issue templates enabled, e.g. https://github.com/ferdium/ferdium-recipes/issues
  3. Click on the 'New issue' link
  4. In the new popup, choose to Sign in
  5. Already now, the return_to parameter shows the wrong URL: %2Fferdium%2Fferdium-recipes%2Fissues%2Fnew (i.e., %2Fchoose is missing at the end)
  6. After the login, you'll find yourself on the wrong page

HTH

@nathanaelhoun
Copy link
Contributor Author

Thanks for the details report @mh166. The link issue in integration.md has been fixed, and for the other, we'll wait on GitHub to fix this behaviour. Thanks for reporting it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📝 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants