Update deps and actions #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SpecialAro
commented
Sep 29, 2023
SpecialAro
commented
- Update 'node' to '20.8.0' and 'pnpm' to '8.8.0' (lock engines)
- Update GH Action to be coherent with PR action
|
I'm merging this PR as is (the errors are currently present in the main build) this will be fixed by the PR on #40 |
mcmxcdev
reviewed
Oct 1, 2023
| @@ -6,9 +6,11 @@ on: | |||
|
|
|||
| jobs: | |||
| check-next-website: | |||
| runs-on: ubuntu-22.04 | |||
There was a problem hiding this comment.
This actually made sense to have locked, since ubuntu-latest could be updated at any time and the pipeline break.
There was a problem hiding this comment.
Ok, we can revert it back. It was just incoherent that we had ubuntu:latest for testing the code and Ubuntu:22.x for deploying
mcmxcdev
reviewed
Oct 1, 2023
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
There is already actions/checkout@v4
There was a problem hiding this comment.
Let's make a PR to update stuff 😁
mcmxcdev
reviewed
Oct 1, 2023
| @@ -9,11 +9,15 @@ jobs: | |||
| build: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: pnpm/action-setup@v2.1.0 | |||
| - uses: actions/checkout@v2 | |||
There was a problem hiding this comment.
There is already actions/checkout@v4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.