Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrals Abstract Types #3

Closed
gustavojra opened this issue Jul 9, 2020 · 0 comments
Closed

Integrals Abstract Types #3

gustavojra opened this issue Jul 9, 2020 · 0 comments

Comments

@gustavojra
Copy link
Member

gustavojra commented Jul 9, 2020

Currently we have defined CCIntegrals which is a type that is passed into the code so we know which CC formulation is appropriated to handle that type of integrals.

Should this be generalized for all methods?

DF-MP2, DF-HF and DF-CC all depende on a DF structured to be passed on.

I think we should create an AbstractIntegral type, where struct (instances) of it can be DensityFitting or Conventional.

This being defined at higher level can lead to a clean up on the methods. Also, instead of having the integrals being handled at the HF part we should store the integrals inside the concrete Integral type.

Here's how it would work.

RHF is called as

RHF(AOIntegrals::Conventional)

RHF(AOIntegrals::DensityFitting)

etc...

So we need to pass integrals into the RHF module. Of course that we also create a simple function

RHF()
   #Use lints to create integral object, call it X
   RHF(X)
end

Thanks for comming to my tedtalk

Sorry this isnt an issue. I was looking for some place to start discussions and post ideas.

gustavojra added a commit that referenced this issue May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant