update template to fix active page #1134
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
|
Will update the PR to have wider clean ups and make this more consistent across all templates. |
tpmccallum
reviewed
Jan 12, 2024
| @@ -251,17 +251,21 @@ | |||
| Kubernetes | |||
| </label> | |||
| <ul class="menu-list accordion-menu-item-content"> | |||
| <li><a {{#if (active_project request.spin-full-url "/spin/v2/kubernetes" )}} class="active" | |||
| {{/if}} href="{{site.info.base_url}}/spin/v2/kubernetes">Spin on Kubernetes</a> | |||
| <li><a {{#if (active_content request.spin-path-info "/kubernetes" )}} class="active" {{/if}} | |||
There was a problem hiding this comment.
Hi @karthik2804
My apologies; I don't understand the changes here active_content vs active_project and path-info vs full-url.
When I preview the documentation side by side with a checkout of this PR they seem to have the same behaviour. I feel like I am totally missing something here.
There was a problem hiding this comment.
HI @tpmccallum This address the issue pointed out in this PR comment
tpmccallum
approved these changes
Jan 12, 2024
|
Will be sure to check this is fully resolved as part of the v3_ToC work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching from highlighting active elements based on a partial match to needing a full match for
/kubernetesas that is a substring in other URLs.If we prefer to update everything to need a full match to keep up with consistency, I can do that as well. But I think I will make a follow-up PR cleaning up templates a little bit.