13 bart formula #15
13 bart formula #15
Conversation
|
@dimitrilw Could you sign the commits for DCO purposes please? You'll probably also need to GPG-sign them (I'm not sure about this repo but a lot of our repos require verified GPG-signed commits). Thanks! |
I'll get that set-up today. |
|
Thank you for advising me to add GPG verification. Done. 
|
|
I see that the DCO req is for every merged commit. The "Details" advises me to rebase & resubmit. Doing that now. 
I apologize for the Github-noob error. I have not used this feature of Github before (as you can tell) and I'm learning as I go. |
dimitrilw
force-pushed
the
13-bart-formula
branch
from
4ee3d75
to
d2073bb
Compare
|
Done. |
|
I see the fails & I'm working to fix. Thank you for being patient with me -- first Homebrew Formula submission, so it is a learning experience. |
|
Updated. |
dimitrilw
force-pushed
the
13-bart-formula
branch
from
6e1de4e
to
eea755d
Compare
|
Also re-updated GPG signature on last commit -- I apologize. I did not realize that I needed to enable git signatures & set as default behavior in:
Adding that note here in case it helps anybody else. |
|
Gah! I apologize. My VS-Code settings are adding that last LF when I commit & push. Manually fixing outside VS-Code. ...I hope I have entertained you all with these errors. 😊 |
|
Of note: I do not understand the other fail on MacOS-13. It shows: |
|
Thanks for all the iterations here @dimitrilw! Do you mind signing your latest commit? My assumption is that the macos workflow there was canceled because the ubuntu workflow errored but i have not dug into it |
|
gah! I thought I had git config'd to auto-sign when I did |
- add initial bart.rb placeholder file - edit readme to ref bart formula NOTE: This Homebrew Formula is not complete. TODO: After binary releases are built for Mac/Linux X Intel/ARM, then un-comment lines & update 'url' & 'sha256' values. Signed-off-by: Dimitri <5898931+dimitrilw@users.noreply.github.com>
Signed-off-by: Dimitri <5898931+dimitrilw@users.noreply.github.com>
Signed-off-by: Dimitri <5898931+dimitrilw@users.noreply.github.com>
Signed-off-by: Dimitri <5898931+dimitrilw@users.noreply.github.com>
Signed-off-by: Dimitri <5898931+dimitrilw@users.noreply.github.com>
Signed-off-by: Dimitri <5898931+dimitrilw@users.noreply.github.com>
dimitrilw
force-pushed
the
13-bart-formula
branch
from
8c40560
to
bd2197e
Compare
|
Done. Thank you for being patient with me. |
|
Thank you @dimitrilw for having the patience to keep at it despite all those potholes! |
There was a problem hiding this comment.
Thank you @dimitrilw for working through all the bot suggestions! I created an issue to figure out how to add windows in the future: #16
|
and just closing loop on this: 🥳 |
Should fix #13 . Also uses a test routine that validates installed version number.