-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timer trigger sample fails to resolve import #1662
Labels
bug
Something isn't working
Comments
dicej
added a commit
to dicej/spin
that referenced
this issue
Jul 17, 2023
The recent `wit-bindgen` update broke this example due to changes in how WIT represents interface and world namespaces. Specifically, the host defines the `config` interface under `fermyon:spin`, whereas the `spin-timer` world is defined under `fermyon:examples`, so we need to tell WIT they're in different packages. Fixes fermyon#1662 Signed-off-by: Joel Dice <joel.dice@fermyon.com>
dicej
added a commit
to dicej/spin
that referenced
this issue
Jul 17, 2023
The recent `wit-bindgen` update broke this example due to changes in how WIT represents interface and world namespaces. Specifically, the host defines the `config` interface under `fermyon:spin`, whereas the `spin-timer` world is defined under `fermyon:examples`, so we need to tell WIT they're in different packages. Fixes fermyon#1662 Signed-off-by: Joel Dice <joel.dice@fermyon.com>
dicej
added a commit
to dicej/spin
that referenced
this issue
Jul 17, 2023
The recent `wit-bindgen` update broke this example due to changes in how WIT represents interface and world namespaces. Specifically, the host defines the `config` interface under `fermyon:spin`, whereas the `spin-timer` world is defined under `fermyon:examples`, so we need to tell WIT they're in different packages. Fixes fermyon#1662 Signed-off-by: Joel Dice <joel.dice@fermyon.com>
dicej
added a commit
that referenced
this issue
Jul 17, 2023
The recent `wit-bindgen` update broke this example due to changes in how WIT represents interface and world namespaces. Specifically, the host defines the `config` interface under `fermyon:spin`, whereas the `spin-timer` world is defined under `fermyon:examples`, so we need to tell WIT they're in different packages. Fixes #1662 Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As part of ongoing component and Wasmtime infrastructure improvements, the
examples/spin-timer
trigger sample was updated in #1615 to refer to the Spinconfig
API in a new way. Unfortunately, although both the trigger and example guest build okay, the example guest fails atspin up
with:I am not sure how to go about fixing this. @rylev @dicej do you have any ideas please? I'm not sure how to share the diff in a text format so here's ye olde GitHub screenshot:
The workaround is to revert the sample to an earlier commit (Spin itself doesn't need to be reverted as the trigger is an independent process).
Incidentally, this highlights a gap in CI - it tests that the sample builds, but doesn't test that it loads and runs - it would be good to improve our coverage here.
The text was updated successfully, but these errors were encountered: