Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(build.yml): only upload to codecov if fermyon org #1008

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

vdice
Copy link
Member

@vdice vdice commented Dec 21, 2022

For now, only attempt to upload codecov reports if this is running on this fermyon origin, where we can guarantee a codecov token is present. Forks may not have such a token and we don't wish to fail their CI runs on this detail.

(We do wish to preserve the fail_ci_if_error toggle so that we're alerted when there are issues uploading when running from the fermyon org, hence keeping this set to true.)

Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
@vdice vdice requested a review from itowlson December 21, 2022 23:07
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, thanks!

@vdice vdice merged commit 04d67d5 into fermyon:main Dec 22, 2022
@vdice vdice deleted the ci/codecov-upload branch December 22, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants