Change spin plugin command to spin plugins retaining singular as an alias
#1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
|
should we also update the SIP: https://github.com/fermyon/spin/blob/main/docs/content/sips/006-spin-plugins.md? |
itowlson
approved these changes
Jan 23, 2023
fibonacci1729
approved these changes
Jan 24, 2023
michelleN
approved these changes
Jan 24, 2023
I don't think we've historically updated SIPs for changes after building the initial feature so I'd say it's not necessary but also don't have a strong opinion here. The docs site should be updated though if there are any references to spin plugin (I didn't see any from a quick scan). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swapping from top-level singular to plural command aligns the command plurality more with templates.
closes #1042
Signed-off-by: Kate Goldenring kate.goldenring@fermyon.com