Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run code coverage only on a schedule #1066

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

itowlson
Copy link
Contributor

Signed-off-by: itowlson ivan.towlson@fermyon.com

Signed-off-by: itowlson <ivan.towlson@fermyon.com>
@itowlson itowlson requested a review from vdice January 26, 2023 19:29
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assume we'll fix lint errors in a separate PR; LGTM!

@itowlson
Copy link
Contributor Author

I think this verifies the syntax even though the flake 🎉 failed 🎉 and the lints have decided to pick today to go berserk:

https://github.com/itowlson/spin/actions/runs/4018501566

@vdice
Copy link
Member

vdice commented Jan 26, 2023

I think this verifies the syntax

Yup, the workflow wouldn't have run if there were syntax errors.

By the way, good call to add the workflow_dispatch support to enable manual triggers as well 👏

@itowlson itowlson merged commit 2312644 into fermyon:main Jan 26, 2023
@vdice vdice mentioned this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants