Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(supply-chain): update audits/exemptions #1106

Merged
merged 3 commits into from
Feb 9, 2023

Conversation

vdice
Copy link
Member

@vdice vdice commented Feb 3, 2023

Update audits and exemptions per failing audit check (also seen in #1107).

@vdice vdice requested a review from radu-matei February 3, 2023 23:03
@vdice vdice added the ci label Feb 3, 2023
@vdice vdice added the dependencies Pull requests that update a dependency file label Feb 3, 2023
Copy link
Member

@michelleN michelleN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vdice Did you run a command to update supply-chain/config.toml. Just wondering what the process looked like for you? Looks like you did a manual check for anyhow 👍 and curious about the rest.

@vdice
Copy link
Member Author

vdice commented Feb 7, 2023

@michelleN yes, I had to at least perform one audit 😂 ; for this, as expected, I followed the steps mentioned in the SIP.

For the exemptions, I started bumping by hand per the cargo vet failures but then the tedium of doing so motivated the creation of a bash script to parse the <dep>:<version> entries from the cargo vet output and run cargo vet add-exemption <dep> <version> on each. (A subsequent cargo vet will cleanup older entries if they exist). Of course, simply bumping exemptions doesn't feed into the long-term goal of actually auditing dependencies, but while we shake out how we'd like our process to look like, it's a stop-gap.

Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
@vdice vdice merged commit 7cbcd4f into fermyon:main Feb 9, 2023
@vdice vdice deleted the chore/cargo-vet branch February 9, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants