-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove assets test #1112
remove assets test #1112
Conversation
Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>
I feel there was some value in having "integration lite" tests with no dependencies (or at most Bindle) that could be run locally relatively quickly and easily, though I'm not sure I ever really ended up catching or diagnosing an issue with them, so eh, maybe not. I guess I don't have strong feelings either way. grin |
Hi Ivan It is a fair point. Thank you for bringing it up. If you are able to run tests using docker compose file (checked-in as part of repo already), will that be a reasonable workaround? I still need to optimize the docker compose process for local laptop and also for arm, but it generally worked for me. I can also add this to Makefile if that makes it any easier. What do u think |
Ah, yep, if I can run specific tests (a la |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming @itowlson is 👍 ; LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yep sorry
Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>
I just pushed a change to add entrypoint to docker compose file to demonstrate how to use (or change) that for running specific tests using docker compose. |
remove assets test as this testcase has been migrated to new e2e tests
spin/tests/testcases/mod.rs
Line 174 in b168540
Signed-off-by: Rajat Jindal rajatjindal83@gmail.com