Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better guidance when unable to upgrade templates #1135

Merged

Conversation

itowlson
Copy link
Contributor

If the user has templates installed with Spin 0.8 or earlier, they will have no info saved saying where they come from, and spin templates upgrade will not work. The current message is a bit misleading. This PR tweaks the experience as follows:

  • User has no templates installed at all - standard "prompt to install the default set" experience:
$ spin templates upgrade
No template repositories found to upgrade

You don't have any templates yet. Would you like to install the default set?
  • User has templates, but none of them have origin information - point them in the right direction to perform an incantatory upgrade:
$ spin templates upgrade
No template repositories found to upgrade

Your template repositories were either:
* Installed from a directory; or
* Installed using an older version of Spin
To upgrade them, run `spin templates install --upgrade` with the --git or --dir option

Very open to bikeshedding wordsmithing on that new text.

Signed-off-by: itowlson ivan.towlson@fermyon.com

Signed-off-by: itowlson <ivan.towlson@fermyon.com>
@itowlson itowlson force-pushed the templates-upgrade-no-origin-handling branch from e539759 to 5cc44b2 Compare February 14, 2023 02:10
@itowlson itowlson merged commit b8e7b27 into fermyon:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants