Add wasi-http trigger support based on wasmtime-wasi-http take 2
#1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required upgrading to a snapshot of what will eventually be Wasmtime 14, as well as upgrading `wit-bindgen` to 0.12. Note that I had to make a copy of wit/preview2 under sdk/rust/macro in order to allow the `http_component` and `redis_component` macros to generate a `wit_bindgen::generate` invocation that actually works. Ideally we'd avoid this duplication, e.g. by using a registry. Signed-off-by: Joel Dice <joel.dice@fermyon.com> address PR feedback - Move `spin_http::empty` and `spin_http::full` into a `body` submodule - Use `Bytes::from_static` where appropriate Signed-off-by: Joel Dice <joel.dice@fermyon.com> update Wasmtime and `spin-componentize` deps to Wasmtime release-14.0.0 branch This also re-enabled wit-bindgen 0.8 support in `spin-componentize` to (hopefully) fix the e2e tests. Signed-off-by: Joel Dice <joel.dice@fermyon.com> add `wasi_http_component` macro to Rust SDK The implementation is pretty ugly given that the inbound and outbound parts of `wasi-http` are tightly coupled, and it's not currently possible to tell `wit_bindgen::generate` to reuse types instead of generating duplicate ones. Signed-off-by: Joel Dice <joel.dice@fermyon.com> Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
dicej
approved these changes
Oct 11, 2023
This was referenced Oct 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a rebased version of #1855 with a couple of additional small commits.