Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release.yml): add crates publishing job #2160

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

vdice
Copy link
Member

@vdice vdice commented Dec 11, 2023

  • Adds a step to publish the spin-sdk crate on each v* release tag

Depends on #2151

TODO:

  • Open Question: What to do re: publishing the spin-macro crate, a dependency of the spin-sdk crate?
    • Keep spin-macro crate version separate from workspace/spin-sdk version (Currently it is 0.1.0)
      • Manually publish crate when this version is bumped, manually create PR to update crate version in spin-sdk's Cargo.toml
      • Add automation to publish crate when this version is bumped (could be slightly tricky if not associated with a git tag), potentially also add automation to create a PR to spin-sdk's Cargo.toml to rev the version
    • Align spin-macro crate version with workspace version (i.e. release tag version) and publish prior to publishing spin-sdk (Haven't tested this, will the approach work via back-to-back jobs in a GH workflow?)

@vdice vdice marked this pull request as ready for review December 12, 2023 21:57
@dicej
Copy link
Contributor

dicej commented Dec 12, 2023

Given that spin-macro changes about as often as spin-sdk, we might as well give them the same version and publish them at the same time.

@vdice vdice added this to the 2.1 milestone Dec 12, 2023
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
@vdice vdice enabled auto-merge (squash) December 13, 2023 15:58
@vdice vdice merged commit 0551e06 into fermyon:main Dec 13, 2023
11 checks passed
@vdice vdice deleted the ci/publish-crates branch December 13, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants