Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(releasing): update release-process.md; add notes template #2622

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

vdice
Copy link
Member

@vdice vdice commented Jul 9, 2024

This updates the Release Process guide with a bit more instruction beyond the pre-existing release branch and git tag steps.

Also adds a release notes template.

This is just a first attempt at adding more details to the process that had previously been tracked elsewhere. Please nitpick, suggest, request more or less detail, point out missing steps, etc!

Copy link
Contributor

@me-diru me-diru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement in the documentation! Pointed out few things I was curious about and maybe improve the Release Engineer's experience.

docs/content/release-notes-template.md Show resolved Hide resolved
docs/content/release-process.md Show resolved Hide resolved

# Create a GPG-signed and annotated tag
git tag -s -m "Spin v2.0.0" v2.0.0
1. If this is a major/minor release or first release candidate, create the release branch, e.g. `v2.0`. With our branch protection rules this is easiest from the Github UI with the [New Branch button here](https://github.com/fermyon/spin/branches).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I know what the first release candidate is?

Copy link
Contributor

@itowlson itowlson Jul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@me-diru The first release candidate is... well, the first candidate for a new release. Like if we are at 3.8, and we are preparing to release 4.0, we might, but do not necessarily, create a 4.0 release candidate. (Usually for minor versions we go straight to a release. Major versions may have RCs.) What this is saying is that, if we decide thr 4.0 release merits a RC, then the 4.0 release branch is created at RC time, not at final release time. And the RC is published from the 4.0 branch.

Does that answer your question? I am not 100% sure what you're asking for here...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks! RC is for one to essentially create a timestamp to release in the future.

docs/content/release-process.md Show resolved Hide resolved
docs/content/release-notes-template.md Show resolved Hide resolved

# Create a GPG-signed and annotated tag
git tag -s -m "Spin v2.0.0-rc.1" v2.0.0-rc.1
## Notify downstream projects
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it is the release engineer's job to announce in Fermyon Discord as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure if they would have the necessary access to post in announcements. I think we could update it accordingly as the project evolves.

Copy link
Member

@mikkelhegn mikkelhegn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- one small question around whether dev docs are in scope

docs/content/release-process.md Show resolved Hide resolved
@vdice vdice force-pushed the docs/release-process-updates branch from 578472e to 3b1fbb3 Compare July 12, 2024 17:52
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
@vdice vdice force-pushed the docs/release-process-updates branch from 3b1fbb3 to 4cca0ef Compare July 12, 2024 20:54
@vdice vdice merged commit 3d78173 into fermyon:main Jul 12, 2024
1 check passed
@vdice vdice deleted the docs/release-process-updates branch July 12, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants