-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(releasing): update release-process.md; add notes template #2622
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvement in the documentation! Pointed out few things I was curious about and maybe improve the Release Engineer's experience.
docs/content/release-process.md
Outdated
|
||
# Create a GPG-signed and annotated tag | ||
git tag -s -m "Spin v2.0.0" v2.0.0 | ||
1. If this is a major/minor release or first release candidate, create the release branch, e.g. `v2.0`. With our branch protection rules this is easiest from the Github UI with the [New Branch button here](https://github.com/fermyon/spin/branches). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I know what the first release candidate is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@me-diru The first release candidate is... well, the first candidate for a new release. Like if we are at 3.8, and we are preparing to release 4.0, we might, but do not necessarily, create a 4.0 release candidate. (Usually for minor versions we go straight to a release. Major versions may have RCs.) What this is saying is that, if we decide thr 4.0 release merits a RC, then the 4.0 release branch is created at RC time, not at final release time. And the RC is published from the 4.0 branch.
Does that answer your question? I am not 100% sure what you're asking for here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks! RC is for one to essentially create a timestamp to release in the future.
|
||
# Create a GPG-signed and annotated tag | ||
git tag -s -m "Spin v2.0.0-rc.1" v2.0.0-rc.1 | ||
## Notify downstream projects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it is the release engineer's job to announce in Fermyon Discord as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure if they would have the necessary access to post in announcements. I think we could update it accordingly as the project evolves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- one small question around whether dev docs are in scope
578472e
to
3b1fbb3
Compare
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
3b1fbb3
to
4cca0ef
Compare
This updates the Release Process guide with a bit more instruction beyond the pre-existing release branch and git tag steps.
Also adds a release notes template.
This is just a first attempt at adding more details to the process that had previously been tracked elsewhere. Please nitpick, suggest, request more or less detail, point out missing steps, etc!