trigger: Tweak wording of AOT compilation code #2682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lann Martin <lann.martin@fermyon.com>
lann
commented
Jul 25, 2024
Comment on lines
-116
to
+123
| format!( | ||
| "failed to read component source from disk at path {}", | ||
| quoted_path(&path) | ||
| ) | ||
| })?; | ||
| let component = spin_componentize::componentize_if_necessary(&bytes)?; | ||
| spin_core::Component::new(engine, component.as_ref()) | ||
| .with_context(|| format!("loading module {}", quoted_path(&path))) | ||
| format!( | ||
| "failed to read component source from disk at path {}", | ||
| quoted_path(&path) | ||
| ) | ||
| })?; | ||
| let component = spin_componentize::componentize_if_necessary(&bytes)?; | ||
| spin_core::Component::new(engine, component.as_ref()) | ||
| .with_context(|| format!("loading module {}", quoted_path(&path))) |
There was a problem hiding this comment.
Just rustfmt having a New Opinion I think...
itowlson
approved these changes
Jul 25, 2024
| AllAotComponents, | ||
| /// No components are ahead of time (AOT) compiled. | ||
| NoneAot, | ||
| Enabled, |
There was a problem hiding this comment.
Enabled suggests more "it's allowed" than "they are," but I imagine anyone who interacts with it will already understand this stuff deeply (certainly deeplier than me!) and it is definitely better than before!
fibonacci1729
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several times I've looked at this
match self.compilation_statusblock and been confused by the wording of the variants.