Give outbound http ability to ban private ips #2808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
force-pushed
the
allow-private-ips
branch
from
40e9938
to
f493669
Compare
lann
approved these changes
Sep 6, 2024
rylev
force-pushed
the
allow-private-ips
branch
from
f493669
to
1bafb22
Compare
|
@lann I added a test. I don't love that the test relies on the actual system DNS resolver and is subject to being messed up if the local system is not what we expect (e.g., someone setting |
rylev
force-pushed
the
allow-private-ips
branch
from
1bafb22
to
54a342a
Compare
lann
approved these changes
Sep 6, 2024
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
rylev
force-pushed
the
allow-private-ips
branch
from
54a342a
to
166b337
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still allow private IPs in Spin CLI, but we might add the ability in the future to turn this off. Other runtimes might also want to take advantage of this feature.