manifest: fix serialization of component dependency section #2842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
lann
approved these changes
Sep 19, 2024
lann
reviewed
Sep 19, 2024
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
fibonacci1729
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the serialization of the
AppManifestin regards to the component dependencies section. Previously usingtry_frommeant that during serialization, the dependencies section had an extra nestedinnerfield, leading to an invalid manifest wherespin upwill error out due to an unknowninnerfield.