Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: remove unused deps #2871

Merged
merged 3 commits into from
Oct 7, 2024
Merged

all: remove unused deps #2871

merged 3 commits into from
Oct 7, 2024

Conversation

Mossaka
Copy link
Contributor

@Mossaka Mossaka commented Oct 1, 2024

remove unused dependencies found by running cargo machete

remove unused dependencies found by running `cargo machete`

Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
crates/sqlite/Cargo.toml Outdated Show resolved Hide resolved
Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
@fibonacci1729
Copy link
Contributor

Looks good! Ran cargo machete myself and noticed a bunch of unused dependencies exist in the tests/examples; would you be up for deleting those in this PR?

@Mossaka
Copy link
Contributor Author

Mossaka commented Oct 3, 2024

yeah sure I will remove these ones from the example/tests

Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
@Mossaka
Copy link
Contributor Author

Mossaka commented Oct 3, 2024

I've removed all deps, except wit-bindgen in tests, which is actually used.

@Mossaka Mossaka closed this Oct 4, 2024
@Mossaka Mossaka reopened this Oct 4, 2024
@fibonacci1729 fibonacci1729 merged commit cd76971 into fermyon:main Oct 7, 2024
32 of 33 checks passed
@Mossaka Mossaka deleted the remove-deps branch October 7, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants