feat: add spin build command to run local build command for components #352

radu-matei · 2022-04-14T00:48:27Z

This commit adds a new top level Spin command that simplifies building more
complex applications. Specifically, this command will execute the build commands
set in each local component configuration:

[component.build]
command = "cargo build --target wasm32-wasi --release --manifest-path http-rust/Cargo.toml"

The build commands for all components in the local application manifest are
currently run sequentially (running multiple resource-intensive compilation processes
concurrently does not seem to be the most efficient choice currently).

Optionally, after all compilation processes are finished, if the --up flag is
passed, the application can be started without calling spin up.

This means that the entire developer "inner loop" for working on a Spin application
can be spin build --up.

Signed-off-by: Radu Matei radu.matei@fermyon.com

crates/build/src/lib.rs

lann · 2022-04-25T13:07:17Z

crates/build/src/lib.rs

+                .context("Component build command must have at least one item.")?;
+
+            Exec::cmd(first)
+                .cwd(


Doesn't need to be this PR, but it would be nice to be able to override this with e.g. component.build.workdir

Opened #406 to track this.

crates/build/src/lib.rs

lann · 2022-04-25T13:12:20Z

src/commands/bindle.rs

@@ -1,21 +1,11 @@
-use crate::parse_buildinfo;
+use crate::{opts::*, parse_buildinfo};


Is this supposed to be in this PR?

nm I get it; not sure the * is worth it here.

There are a lot of opts in this file, I'd rather not import every single one..

src/commands/build.rs

src/opts.rs

radu-matei · 2022-04-26T01:45:19Z

I think I addressed most of the comments, @lann.

src/commands/build.rs

This commit adds a new top level Spin command that simplifies building more complex applications. Specifically, this command will execute the build commands set in each local component configuration: ```toml [component.build] command = "cargo build --target wasm32-wasi --release --manifest-path http-rust/Cargo.toml" ``` The build commands for all components in the local application manifest are currently run sequentially (running multiple resource-intensive compilation processes concurrently does not seem to be the most efficient choice currently). Optionally, after all compilation processes are finished, if the `--up` flag is passed, the application can be started without calling `spin up`. This means that the entire developer "inner loop" for working on a Spin application can be `spin build --up`. Signed-off-by: Radu Matei <radu.matei@fermyon.com> feat Signed-off-by: Radu Matei <radu.matei@fermyon.com> feat Signed-off-by: Radu Matei <radu.matei@fermyon.com>

radu-matei · 2022-04-26T21:07:15Z

Ok, did another round of updates to this PR, most importantly, command is now a single string, which will be executed by a shell.

lann mentioned this pull request Apr 21, 2022

Feature: App integration testing harness #383

Closed

radu-matei mentioned this pull request Apr 21, 2022

docs(sip): add spin build SIP #384

Merged

radu-matei force-pushed the spin-build-local-dev branch from bfcf3e1 to fc0419d Compare April 25, 2022 03:14

radu-matei marked this pull request as ready for review April 25, 2022 03:14