chore(ci): stop cancelling concurrent runs #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fermyon#170 introduced cancelling in-progress workflow runs for builds, which made sense when we were constrained on build minutes. However, this seems to cancel in-progress runs quite often for both in-flight PRs *and* for builds on `main`, which means that we regularly have to manually re-run builds for both PRs and on main (when the overall status of the repository is failed, because a job was cancelled). This commit removes the "cancel-in-progress" condition for builds. Signed-off-by: Radu Matei <radu.matei@fermyon.com>
vdice
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#170 introduced cancelling in-progress
workflow runs for builds, which made sense when we were constrained on build
minutes.
However, this seems to cancel in-progress runs quite often for both in-flight
PRs and for builds on
main, which means that we regularly have to manuallyre-run builds for both PRs and on main (when the overall status of the repository
is failed, because a job was cancelled).
This commit removes the "cancel-in-progress" condition for builds.
Signed-off-by: Radu Matei radu.matei@fermyon.com