-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate component IDs are unique #370
Conversation
While you're iterating on the PR, keep an eye out for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one - thanks for tackling this. I had just a couple of suggestions but otherwise looks good!
Applied the feedback and am happier with how the code looks now. Thanks again for feedback! I'll squash my commits after a review unless there are more changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your contribution, @0xcodeboi!
LGTM
The
spin.toml
configuration file currently loads without error when multiple components use the sameid
. This PR adds a uniqueness constraint in theloader
crate which will fail to load a configuration file with multiple defined components sharing an identifier.See #340 for more details.