feat(sdk/go): Add SIP-002 "Application Configuration" to TinyGo SDK #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreese
force-pushed
the
feat/sdk-go-config
branch
from
0a41952
to
2b28b9b
Compare
radu-matei
reviewed
May 5, 2022
radu-matei
reviewed
May 5, 2022
examples/config-tinygo/main.go
Outdated
| "fmt" | ||
| "net/http" | ||
|
|
||
| spinconfig "github.com/fermyon/spin/sdk/go/config" |
There was a problem hiding this comment.
I'm torn between prefixing spin* before packages everywhere, or just where it clashes with standard library packages.
(nothing to change here, just wondering what your thoughts are)
There was a problem hiding this comment.
I think only where it clashes.
radu-matei
reviewed
May 5, 2022
adamreese
force-pushed
the
feat/sdk-go-config
branch
from
2b28b9b
to
c5af74a
Compare
adamreese
force-pushed
the
feat/sdk-go-config
branch
from
c5af74a
to
5bceadf
Compare
Signed-off-by: Adam Reese <adam@reese.io>
adamreese
force-pushed
the
feat/sdk-go-config
branch
from
5bceadf
to
e503f6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.