Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename config Path to TreePath #405

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Rename config Path to TreePath #405

merged 1 commit into from
Apr 26, 2022

Conversation

lann
Copy link
Collaborator

@lann lann commented Apr 26, 2022

Path looks too much like Path.

ref #401

@lann lann requested a review from itowlson April 26, 2022 21:02
itowlson
itowlson approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LLCTM

@lann lann merged commit 3cf8c37 into fermyon:main Apr 26, 2022
@lann lann deleted the rename-tree-path branch April 26, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radu-matei radu-matei radu-matei approved these changes

@itowlson itowlson itowlson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lann @itowlson @radu-matei