Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: default Application generic type to CoreComponent #430

Merged
merged 4 commits into from
May 3, 2022

Conversation

Mossaka
Copy link
Contributor

@Mossaka Mossaka commented May 3, 2022

resolve issue #414

Signed-off-by: Jiaxiao Zhou jiazho@microsoft.com

Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
@Mossaka
Copy link
Contributor Author

Mossaka commented May 3, 2022

@lann for review

@Mossaka Mossaka changed the title default Application generic type to CoreComponent refactor: default Application generic type to CoreComponent May 3, 2022
Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
Copy link
Collaborator

@lann lann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lann lann merged commit 3dc01f5 into fermyon:main May 3, 2022
@Mossaka Mossaka deleted the jiazho/application_no_generic branch May 3, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants