add with_wasmtime_engine() to Builder #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
lann
previously requested changes
May 4, 2022
Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
|
Made an update to add the Engine struct and a getter function @lann |
Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
lann
reviewed
May 9, 2022
lann
requested changes
May 9, 2022
Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
Signed-off-by: Lann Martin <lann.martin@fermyon.com>
lann
approved these changes
May 10, 2022
|
let's merge this in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dataandstoretobuild()Related to issue #436
Signed-off-by: Jiaxiao Zhou jiazho@microsoft.com