perf: reduce peak memory usage and open files when loading bindle #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This reduces peak memory usage from ~200MB to |
itowlson
approved these changes
May 4, 2022
crates/loader/src/bindle/assets.rs
Outdated
| .await | ||
| .with_context(|| anyhow!("Failed to fetch asset parcel '{}@{}'", self.id, p.sha256))?; | ||
|
|
||
| let mut file = fs::File::create(&to).await?; |
There was a problem hiding this comment.
Could we add a with_context(...) here so that the user can see where the failure was and which file/parcel it occurred on?
There was a problem hiding this comment.
Good catch -- done.
Clippy also caught a bug, so I fixed that, too. Note to self: for x in stream.try_next().await? { .. } almost certainly does not do what you want it to do.
This patch does two things: 1. Use `bindle::client::Client::get_parcel_stream` instead of `get_parcel`. The latter loads the whole asset into memory, while the former allows us to stream into a local file chunk-by-chunk. 2. Limit parallel I/O in `spin_loader::bindle::assets::Copier` to avoid hammering the Bindle server and also avoid running out of file descriptors. This addresses fermyon#413. Signed-off-by: Joel Dice <joel.dice@gmail.com>
lann
reviewed
May 4, 2022
| .into_iter() | ||
| .filter_map(|r| r.err()) | ||
| match stream::iter(parcels.iter().map(|p| self.copy(p, &dir))) | ||
| .buffer_unordered(MAX_PARALLEL_COPIES) |
There was a problem hiding this comment.
@adamreese I knew this was implemented somewhere!
radu-matei
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch does two things:
Use
bindle::client::Client::get_parcel_streaminstead ofget_parcel. Thelatter loads the whole asset into memory, while the former allows us to stream
into a local file chunk-by-chunk.
Limit parallel I/O in
spin_loader::bindle::assets::Copierto avoidhammering the Bindle server and also avoid running out of file descriptors.
This addresses #413.
Signed-off-by: Joel Dice joel.dice@gmail.com