Allow parcel ref in component source #456
Conversation
itowlson
force-pushed
the
wasm-bindle-parcel-source
branch
from
0d40e3f
to
021f630
Compare
|
In the longer term - if we wanted loaders and publishers to be pluggable - all the bindle code could move into a |
| username: Option<String>, | ||
| password: Option<String>, |
There was a problem hiding this comment.
How about something like this, to allow easier extension to other auth types:
pub fn basic_auth(&mut self, username: String, password: String) ...There was a problem hiding this comment.
I see this is copied from publish, so this doesn't need to be in scope for this PR.
| /// Returns a client based on this instance's configuration | ||
| pub fn client(&self) -> bindle::client::Result<Client<AnyAuth>> { | ||
| let builder = ClientBuilder::default() | ||
| .http2_prior_knowledge(false) |
There was a problem hiding this comment.
This appears to be the default...
There was a problem hiding this comment.
I think when this code was written it was not the default (in fact I think I had to add the option so I could set it to false), so this is historical I guess... but unless the default is contractual (that is, it would be documented as a breaking change if they changed it), I'm inclined to set this explicitly. (Ultimately it should be under config control.)
itowlson
force-pushed
the
wasm-bindle-parcel-source
branch
3 times, most recently
from
8f89076
to
f270293
Compare
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson
force-pushed
the
wasm-bindle-parcel-source
branch
from
f270293
to
6afcc55
Compare
Fixes #454.
This duplicates the
BindleConnectioninfoinfrastructure from the Hippo CLI and thebindle pushcommand. It looks like thepublishcrate depends onloaderso we can probably remove it frompublish, though it feels a bit weird forloaderto be the one to export it - it's not the obvious place a consumer would look for it. We should discuss where we want things like this to live.It may be that there's a nicer way of threading the connection info through the loader - very much open to suggestions here.
TO DONOW DONE: