Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if bindle already exists before pushing #459

Merged
merged 1 commit into from
May 10, 2022
Merged

Check if bindle already exists before pushing #459

merged 1 commit into from
May 10, 2022

Conversation

itowlson
Copy link
Contributor

@itowlson itowlson commented May 9, 2022

Fixes #458.

@itowlson
Check if bindle already exists before pushing
2136dd6 
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
@itowlson itowlson force-pushed the fail-push-if-bindle-id-exists branch from 044fb4b to 2136dd6 Compare May 9, 2022 22:55
radu-matei
radu-matei approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, tested, and it now works as expected.

LGTM

@itowlson itowlson merged commit b4aa7aa into fermyon:main May 10, 2022
This was referenced May 17, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radu-matei radu-matei radu-matei approved these changes

@michelleN michelleN Awaiting requested review from michelleN

@vdice vdice Awaiting requested review from vdice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spin bindle push does not error if invoice exists
2 participants
@itowlson @radu-matei