-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Makefile): add make doc command #485
Conversation
+ adds a `doc` make target that generates a new doc from template + can take name of document on command line optionally + usage: SPIN_DOC_NAME=mydocument.md make doc Signed-off-by: Michelle Dhanani <michelle@fermyon.com>
Rather than a bespoke script, I'd rather add the missing features to
It seems like it could be useful to either have a template |
Just wanted to make it easier to write docs without another dependency/tool in the mix. I think a template.md file would be great. |
closing in favor of #488 |
@radu-matei re-opened this for more discussion. The thought occurred to me last night that the whole reason I wanted this make command is so I didn't have to use bart to generate the date for me. Otherwise, I would just copy/paste. Also, I kinda like this date format a little better because it's easier to understand. Do you think the process should be create a template, copy/paste, insert the date manually and then put your content in? I just feel like the make target takes so much thought out of the whole thing like it puts the file in the place it needs to be, generates the date for you, etc. Why do we need to stick to using bart? What is the dependency here? Maybe I am missing something. |
We definitely don't need to use For transparency, I've been copy-pasting the page headers in all docs I've written a while back, so having this target helps for sure, happy to have it merged. I still think adding this to the CLI would be a good idea, and I should have been a bit more clear that this PR and improving Bart are not mutually exclusive! Thanks! |
I see! Thanks for explaining @radu-matei ! I don't see anything missing from the bart CLI for the record. |
doc
make target that generates a new docfrom template
Signed-off-by: Michelle Dhanani michelle@fermyon.com