Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: support automatically release checksums and binaries #496

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

Xunzhuo
Copy link
Contributor

@Xunzhuo Xunzhuo commented May 14, 2022

Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks excellent, thank you for adding @Xunzhuo ! LGTM

@vdice
Copy link
Member

vdice commented May 16, 2022

@Xunzhuo one last detail. Would it be possible to add your GPG signature to the commit per https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification? Thank you.

@radu-matei
Copy link
Member

Thank you so much, @Xunzhuo!
Once you add your commit signature, this LGTM.

Thank you so much!

@Xunzhuo
Copy link
Contributor Author

Xunzhuo commented May 18, 2022

Thanks @vdice and @radu-matei, I am on a vacation, so my computer is away from me, I will update commit signature ASAP:)

@radu-matei
Copy link
Member

No worries, enjoy your vacation!

@radu-matei
Copy link
Member

Hey, @Xunzhuo, bump on the commit signature here.

Thanks again for your contribution!

@Xunzhuo
Copy link
Contributor Author

Xunzhuo commented Jun 13, 2022

Hi @radu-matei, I checked that I have excuted git commit -s -m "xxx", what else should I do?

@vdice
Copy link
Member

vdice commented Jun 13, 2022

@Xunzhuo you may need to force-push the signed commit, to re-trigger the check. Can you give this a try?

@radu-matei
Copy link
Member

You also need to sign with a GPG key — see https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

(git commit -S -s -m "")

@vdice vdice added this to the v0.3.0 milestone Jun 14, 2022
@vdice
Copy link
Member

vdice commented Jun 16, 2022

Hi @Xunzhuo , sorry for all of the trouble here. We are very close! The recent merge commit is properly signed per the 'Verified' indicator:
Screen Shot 2022-06-16 at 8 34 26 AM

Alas, the original commit still needs signing with a GPG key:
Screen Shot 2022-06-16 at 8 34 33 AM

One way would be to rebase this branch and squash commits down to one, GPG-signed commit. Do you think you might have a chance to do this?

We're excited to get this in and use it for the forthcoming release! Thank you.

@vdice vdice removed this from the v0.3.0 milestone Jun 16, 2022
@Xunzhuo Xunzhuo force-pushed the main branch 2 times, most recently from 6154347 to 92c6fbc Compare June 17, 2022 03:39
Signed-off-by: Xunzhuo <mixdeers@gmail.com>
@Xunzhuo
Copy link
Contributor Author

Xunzhuo commented Jun 17, 2022

Hi @Xunzhuo , sorry for all of the trouble here. We are very close! The recent merge commit is properly signed per the 'Verified' indicator: Screen Shot 2022-06-16 at 8 34 26 AM

Alas, the original commit still needs signing with a GPG key: Screen Shot 2022-06-16 at 8 34 33 AM

One way would be to rebase this branch and squash commits down to one, GPG-signed commit. Do you think you might have a chance to do this?

We're excited to get this in and use it for the forthcoming release! Thank you.

Thanks @vdice and @radu-matei , I did not use GPG before just using SSH. After configuring some steps, finally solved this:) Sorry for the delay.

@Xunzhuo Xunzhuo requested a review from vdice June 17, 2022 05:46
@Xunzhuo
Copy link
Contributor Author

Xunzhuo commented Jun 17, 2022

I tested this again, see https://github.com/Xunzhuo/spin/releases/tag/v0.6.0, uploading artifacts is working well, but the automated release title is like that, should we fix this? Or let release manager to manually edit this?

@radu-matei
Copy link
Member

cc @vdice for a final review.

Thank you for your contribution, @Xunzhuo!

@vdice
Copy link
Member

vdice commented Jun 17, 2022

I tested this again, see https://github.com/Xunzhuo/spin/releases/tag/v0.6.0, uploading artifacts is working well, but the automated release title is like that, should we fix this? Or let release manager to manually edit this?

First, thanks for testing again. Good question; I think for now we'll assume the release manager will manually edit the release. I/we can look at further action configuration (or alternate actions) that might provide functionality to set the release title and, ideally, utilize GitHub's auto-generated release notes functionality. Meanwhile, we're excited to bring in these excellent improvements! Thanks again @Xunzhuo 🎉

@vdice vdice merged commit e316792 into fermyon:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update release workflow to automatically upload artifacts
3 participants