Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(.gitignore): ignore .vscode config #511

Merged
merged 1 commit into from
May 18, 2022

Conversation

michelleN
Copy link
Member

Signed-off-by: Michelle Dhanani michelle@fermyon.com

@michelleN michelleN marked this pull request as ready for review May 18, 2022 20:16
@itowlson
Copy link
Contributor

Won't this result in excluding things like the Rust and Go language server settings?

(It's frustrating because one wants to exclude settings like colour schemes but include actual workspace settings but VS Code doesn't seem to have a way to split those files.)

Also we don't currently use it but ./vscode is where launch.json and tasks.json live and if we ever have those they should definitely travel with the project.

Signed-off-by: Michelle Dhanani <michelle@fermyon.com>
@michelleN
Copy link
Member Author

@itowlson - great points! Thank you. I updated the gitignore to only ignore *.log files which are the files annoying me on my machine. Does this change make sense to apply?

@itowlson
Copy link
Contributor

Wow, it's pretty rude of VS Code to drop log files there. Yes, completely agree on ignoring them!

Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michelleN michelleN merged commit 141a125 into fermyon:main May 18, 2022
@michelleN michelleN deleted the ignorevscodeconfig branch May 18, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants