Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install stable templates if using stable build #518

Merged

Conversation

itowlson
Copy link
Contributor

This is a partial fix for #517.

It's partial because we need a longer term strategy for things like this, whether that's keeping HEAD on the 'stable' branch or auto inferring the matching tag or what. Perhaps a topic for the Spin meeting. It's also partial because it's not sustainable, we don't want to have to rev this as part of every release!

Is it possible to get this fix rolled out to the 0.2.0 docs site, please?

Signed-off-by: itowlson <ivan.towlson@fermyon.com>
@itowlson itowlson force-pushed the stable-build-needs-templates-from-tag branch from b2a4e48 to 8bb093d Compare May 22, 2022 22:54
@lann
Copy link
Collaborator

lann commented May 23, 2022

Perhaps we should have a stable (or something; "stable" might be misleading at this point...) branch that tracks the latest release?

Copy link
Member

@michelleN michelleN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested and works! Although I also like @lann's suggestion. Maybe we could call it latest-release?

@itowlson
Copy link
Contributor Author

chuckle agree that stable is stretching it right now, but something along those lines seems like a nice simple solution.

Shall I merge this now so we can push new docs, and then get it to use the default tag when we've decided what to call it?

@radu-matei
Copy link
Member

cc @vdice for updating the stable docs website.

@itowlson itowlson merged commit c7626ca into fermyon:main May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants