-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add docs for spin build workdir #531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I just a simple nit/clarity question.
docs/content/developing.md
Outdated
workdir = "deep" | ||
``` | ||
|
||
Note that `workdir` must be a relative path, specifying an absolute path leads |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to mention here that workdir
operates relative to the spin.toml
? Or is that obvious given the Note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point, I think it's worth mentioning it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, it is mentioned now.
Excellent, thanks! |
Signed-off-by: Moritz <moritz.zielke@gmail.com>
Thank you for your contribution, @mooori! |
Documents the feature to specify the directory in which a component's build command is run.
ref #515
Signed-off-by: Moritz moritz.zielke@gmail.com