Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docs for spin build workdir #531

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Conversation

mooori
Copy link
Contributor

@mooori mooori commented May 31, 2022

Documents the feature to specify the directory in which a component's build command is run.

ref #515

Signed-off-by: Moritz moritz.zielke@gmail.com

@mooori mooori marked this pull request as ready for review May 31, 2022 13:28
Copy link
Contributor

@fibonacci1729 fibonacci1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I just a simple nit/clarity question.

workdir = "deep"
```

Note that `workdir` must be a relative path, specifying an absolute path leads
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to mention here that workdir operates relative to the spin.toml? Or is that obvious given the Note.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point, I think it's worth mentioning it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, it is mentioned now.

@radu-matei
Copy link
Member

Excellent, thanks!
Would you mind squashing (and signing again), please?

Signed-off-by: Moritz <moritz.zielke@gmail.com>
@radu-matei
Copy link
Member

Thank you for your contribution, @mooori!

@radu-matei radu-matei merged commit 6b88731 into fermyon:main Jun 9, 2022
@mooori mooori deleted the doc-wd branch June 9, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants