-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Begin replacing wit_bindgen with Rust SDK in integration tests #534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @ejmg ! This all looks great. I think we can open a new issue regarding the note you left to make the logic of these tests (in the component) a little more robust. Would you mind dropping the note you left into an issue linking this PR?
Sounds good to me. I am getting into the car to take off for a small
camping trip until this Wednesday so I’ll file it myself if it can wait
until then; I planned on seeing through the PR either way.
…On Sat, Jun 4, 2022 at 4:47 PM Brian ***@***.***> wrote:
***@***.**** approved this pull request.
Thanks for the PR @ejmg <https://github.com/ejmg> ! This all looks great.
I think we can open a new issue regarding the note you left to make the
logic of these tests (in the component) a little more robust. Would you
mind dropping the note you left into an issue linking this PR?
—
Reply to this email directly, view it on GitHub
<#534 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEK7ZPRTLB22AWU52OJGGDTVNPFGXANCNFSM5X2JQMDQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sounds great! Most of the Fermyon folks are returning from an offsite this week so no rush! Happy camping! 🏕 |
Welp, camping plans changed. I'll open up a new issue with my comment and let me know if there is anything else I need to do on this PR before it gets merged. |
This looks great, thank you, @ejmg! |
Sorry for redundant commit, I missed the newline comment! I've signed off and verified my commits along with the suggested edits. |
@radu-matei and @fibonacci1729, I've updated this single test case to replicate the previous behavior of the test binary used by the integrations tests. To actually assert correctness, we would probably need to check the contents of the body but this is closer to correct behavior. The one thing I'm wondering about right now (and as you'll see as a some |
Re: your note — you're not actually changing the response of the Wasm component itself. (for a bit more context on the WIT design for the HTTP component, which we might want to change eventually — the In terms of the commits, would you please squash to a single commit that is signed? Thanks, and apologies for the git friction here.. |
…rmyon#216 Signed-off-by: elias <elias.jm.garcia@gmail.com>
601419d
to
d59ffe5
Compare
@radu-matei good to go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, @ejmg!
LGTM
This PR addresses #216.
I'll need some feedback on the intended behavior for these tests to ensure the integrations are still checking for the desired behavior and functionality.