Remove vendored-openssl feature #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fibonacci1729
approved these changes
Jun 10, 2022
dicej
reviewed
Jun 10, 2022
It turns out this can be replaced with `--features openssl/vendored`, which allows us to toggle the feature independently from --all-features. Use `openssl/vendored` for Linux builds to maintain static linking for releases. Signed-off-by: Lann Martin <lann.martin@fermyon.com>
lann
force-pushed
the
remove-vendored-openssl-feature
branch
from
019951e
to
c354628
Compare
dicej
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out this can be replaced with
--features openssl/vendored,which allows us to toggle the feature independently from --all-features.
Use
openssl/vendoredfor Linux builds to maintain static linking forreleases.
Signed-off-by: Lann Martin lann.martin@fermyon.com